ci: pin docker actions to commit SHA#2328
Open
mesutoezdil wants to merge 2 commits into
Open
Conversation
mesutoezdil
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 16, 2026 19:28
elezar
reviewed
Jul 17, 2026
login-action and setup-buildx-action used a mutable version tag while every other action in the repo is pinned to a commit SHA. Pin both, and align login-action to the same v4 SHA already used in ci-image.yml. Use the full resolved version in the trailing comment (v3.12.0) to match the more common convention used elsewhere in .github/.
mesutoezdil
force-pushed
the
ci/pin-docker-actions
branch
from
July 17, 2026 13:02
81a48db to
895b986
Compare
Contributor
|
hello, is it possible to enforce that on the GitHub configuration of this repository so only pinned actions can be run [1] [2] ? [1] https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions |
Contributor
Author
makes sense from my side |
Collaborator
|
/ok to test 1b60a24 |
krishicks
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker/login-action and docker/setup-buildx-action were on a mutable version tag (@V3) while every other third-party action in the repo is pinned to a commit SHA. This pins both.
login-action is aligned to the same v4 SHA already pinned in ci-image.yml, so the repo uses one version consistently instead of v3 in one place and v4 in another.