fix(e2e): clean up temp files in sandbox-runner on exit#1647
Merged
Conversation
mesutoezdil
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
Collaborator
|
/ok to test a2460b8 |
johntmyers
approved these changes
Jun 1, 2026
jhjaggars
pushed a commit
to jhjaggars/OpenShell
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sandbox-runner.shusedmktempon every call but had no cleanup.Temp files leaked into
/tmpfor the lifetime of the sandbox.e2e/policy-advisor/sandbox-runner.sh: one temp dir at startup, removed on exit viatrap.All
mktempcalls replaced with paths inside that dir.Testing
bash -n: syntax OKshellcheck: no warningsmise run pre-commit: all tests pass