feat(cli): support multiple --upload flags on sandbox create (#1635)#1645
Open
feloy wants to merge 1 commit into
Open
feat(cli): support multiple --upload flags on sandbox create (#1635)#1645feloy wants to merge 1 commit into
feloy wants to merge 1 commit into
Conversation
…1635) Closes NVIDIA#1635 Signed-off-by: Philippe Martin <phmartin@redhat.com>
feloy
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1635
Summary
Changes
--uploadonsandbox createfrom a singleOption<String>to a repeatableVec<String>, so users can seed a sandbox with multiple paths in one command without needing a post-creationsandbox uploadstep.Related Issue
Closes #1635
Changes
crates/openshell-cli/src/main.rs:uploadfield changed toVec<String>; all local paths are validated upfront before the sandbox is created; three new CLI-parse tests addedcrates/openshell-cli/src/run.rs:sandbox_createnow accepts&[(String, Option<String>, bool)]and iterates over each spec sequentially; progress output shows[1/N]counters when multiple uploads are presentcrates/openshell-cli/tests/sandbox_create_lifecycle_integration.rs: updated 10 call sites fromNoneto&[]to match the new signaturedocs/sandboxes/manage-sandboxes.mdx: updated the--uploadnote with a multi-upload examplee2e/rust/src/harness/sandbox.rs: addedcreate_with_uploadshelper accepting multiple(local, dest)pairs;create_with_uploaddelegates to ite2e/rust/tests/upload_create.rs: addedcreate_with_multiple_uploadstest that uploads two directories in onesandbox createcall and asserts both appear in outputTesting
mise run pre-commitpassesChecklist