Skip to content

chore: Set minimum Node.js version to 24#146

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
dagardner-nv:david-relay03
May 22, 2026
Merged

chore: Set minimum Node.js version to 24#146
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
dagardner-nv:david-relay03

Conversation

@dagardner-nv
Copy link
Copy Markdown
Contributor

@dagardner-nv dagardner-nv commented May 21, 2026

Overview

Set minimum Node.js version to 24, since that is the version we use in CI.

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

  • Remove *.profraw files from root of the repo and integrations/openclaw/

Where should the reviewer start?

  • justfile

Summary by CodeRabbit

  • Chores

    • Enhanced local cleanup to remove profiling (.profraw) files.
    • Updated development dependency for Node type definitions.
  • Documentation

    • Raised the documented minimum Node.js requirement to version 24 across guides and READMEs.

Review Change Stack

Signed-off-by: David Gardner <dagardner@nvidia.com>
…or (at least with node v20)

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this May 21, 2026
@dagardner-nv dagardner-nv requested a review from a team as a code owner May 21, 2026 23:29
@github-actions github-actions Bot added the size:XS PR is extra small label May 21, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Caution

Review failed

Failed to post review comments

Walkthrough

Node.js minimum runtime bumped to 24 across package metadata and docs; attribution records for Node-related types updated; OpenClaw package devDependency for @types/node bumped; justfile clean target extended to remove *.profraw profiling artifacts.

Changes

Node engine & cleanup updates

Layer / File(s) Summary
Node engine constraint and docs/attributions
package.json, crates/node/package.json, crates/wasm/package.json, docs/getting-started/prerequisites.md, docs/reference/api/nodejs/index.md, crates/node/README.md, AGENTS.md, ATTRIBUTIONS-Node.md
Update Node.js engines.node/prerequisite statements from 20/>=20.0.0 to 24/>=24.0.0; bump @types/node and undici-types entries in attributions.
OpenClaw devDependency bump
integrations/openclaw/package.json
Change devDependencies.@types/node from ^20.19.0 to ^24.0.0.
Profiling artifact cleanup
justfile
Extend clean target to remove *.profraw and integrations/openclaw/*.profraw profiling artifact files.

🎯 3 (Moderate) | ⏱️ ~20 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title follows Conventional Commits format with 'chore' type and is under 72 characters, but 'Misc build cleanups' is vague and does not clearly summarize the main changes (Node.js version bump to 24, profraw cleanup, test glob fix). Consider a more specific title that reflects the primary change, such as 'chore: Bump minimum Node.js version to 24' or 'chore(node): Update minimum version to 24 and cleanup build artifacts'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description includes the required template sections (Overview with checklist, Details, Where to start) with substantive content about the changes and includes error context, though it omits the Related Issues section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

willkill07
willkill07 previously approved these changes May 21, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
integrations/openclaw/package.json (1)

1-1: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add SPDX metadata to integrations/openclaw/package.json

  • integrations/openclaw/package.json has no SPDX-License-Identifier marker (only "license": "Apache-2.0"), while the repo uses an SPDX field in other JSON (e.g., integrations/coding-agents/codex/hooks/hooks.json).
  • Since JSON can’t carry SPDX via comment headers, align with the repo’s JSON SPDX convention or document an explicit exemption for package.json.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@integrations/openclaw/package.json` at line 1, Package JSON lacks the repo's
JSON SPDX marker; update integrations/openclaw/package.json to include the SPDX
identifier alongside the existing "license": "Apache-2.0" (e.g., add a top-level
"SPDX-License-Identifier": "Apache-2.0") so it matches the repo's JSON SPDX
convention used in other files, or if package.json is intentionally exempt, add
documentation noting the exemption; locate the file and add the SPDX field at
the top-level of the JSON (referencing the "license" key for consistency).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@justfile`:
- Line 796: Update the glob used for OpenClaw profiling artifacts to be
recursive for consistency with the crates pattern: replace the literal pattern
"integrations/openclaw/*.profraw" with a recursive glob
"integrations/openclaw/**/*.profraw" so it matches files in any subdirectory
(aligning with "crates/**/*.profraw").

---

Outside diff comments:
In `@integrations/openclaw/package.json`:
- Line 1: Package JSON lacks the repo's JSON SPDX marker; update
integrations/openclaw/package.json to include the SPDX identifier alongside the
existing "license": "Apache-2.0" (e.g., add a top-level
"SPDX-License-Identifier": "Apache-2.0") so it matches the repo's JSON SPDX
convention used in other files, or if package.json is intentionally exempt, add
documentation noting the exemption; locate the file and add the SPDX field at
the top-level of the JSON (referencing the "license" key for consistency).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 53498738-2510-4a4e-81d0-d6823f4fab4b

📥 Commits

Reviewing files that changed from the base of the PR and between 8f096e7 and c8b4944.

📒 Files selected for processing (2)
  • integrations/openclaw/package.json
  • justfile
📜 Review details
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{rs,py,js,ts,mjs,go,sh,toml,yml,yaml,md,json,css,html}

📄 CodeRabbit inference engine (AGENTS.md)

Keep SPDX headers on source, docs, scripts, and configuration files. The project is Apache-2.0.

Files:

  • integrations/openclaw/package.json
**/package.json

📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)

Update Node.js package names during coordinated rename operations

Files:

  • integrations/openclaw/package.json
integrations/openclaw/package.json

📄 CodeRabbit inference engine (.agents/skills/update-project-version/SKILL.md)

Ensure integrations/openclaw/package.json npm plugin version stays aligned with the workspace-root package-lock.json

Files:

  • integrations/openclaw/package.json
{docs/**,README.md,**/Cargo.toml,**/package.json,**/*.md}

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

Ensure renamed public surfaces are reflected consistently in manifests and docs for large or public-facing changes

Files:

  • integrations/openclaw/package.json
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}

⚙️ CodeRabbit configuration file

{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}: Review automation changes for reproducibility, pinned versions where appropriate, secret handling, and consistency with the documented validation matrix.
Pay attention to commands that need generated native artifacts, FFI libraries, or platform-specific environment variables.

Files:

  • justfile
🔇 Additional comments (2)
integrations/openclaw/package.json (1)

59-59: LGTM!

justfile (1)

785-785: LGTM!

Comment thread justfile
@willkill07 willkill07 changed the title Misc build cleanups chore: Misc build cleanups May 21, 2026
@github-actions github-actions Bot added the Maintenance CI or Build or general repository maintenance label May 21, 2026
Signed-off-by: David Gardner <dagardner@nvidia.com>
…ound error (at least with node v20)"

This reverts commit c8b4944.

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv requested a review from a team as a code owner May 22, 2026 00:02
@github-actions github-actions Bot added size:S PR is small and removed size:XS PR is extra small labels May 22, 2026
@dagardner-nv dagardner-nv changed the title chore: Misc build cleanups chore: Set minimum Node.js version to 24 May 22, 2026
@dagardner-nv dagardner-nv requested a review from willkill07 May 22, 2026 00:04
Copy link
Copy Markdown
Collaborator

@Salonijain27 Salonijain27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a dependency point of view

@willkill07
Copy link
Copy Markdown
Member

/merge

@rapids-bot rapids-bot Bot merged commit 8a04939 into NVIDIA:main May 22, 2026
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI or Build or general repository maintenance size:S PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants