chore: Set minimum Node.js version to 24#146
Conversation
Signed-off-by: David Gardner <dagardner@nvidia.com>
…or (at least with node v20) Signed-off-by: David Gardner <dagardner@nvidia.com>
|
Caution Review failedFailed to post review comments WalkthroughNode.js minimum runtime bumped to 24 across package metadata and docs; attribution records for Node-related types updated; OpenClaw package devDependency for ChangesNode engine & cleanup updates
🎯 3 (Moderate) | ⏱️ ~20 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
integrations/openclaw/package.json (1)
1-1:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd SPDX metadata to integrations/openclaw/package.json
integrations/openclaw/package.jsonhas noSPDX-License-Identifiermarker (only"license": "Apache-2.0"), while the repo uses an SPDX field in other JSON (e.g.,integrations/coding-agents/codex/hooks/hooks.json).- Since JSON can’t carry SPDX via comment headers, align with the repo’s JSON SPDX convention or document an explicit exemption for
package.json.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@integrations/openclaw/package.json` at line 1, Package JSON lacks the repo's JSON SPDX marker; update integrations/openclaw/package.json to include the SPDX identifier alongside the existing "license": "Apache-2.0" (e.g., add a top-level "SPDX-License-Identifier": "Apache-2.0") so it matches the repo's JSON SPDX convention used in other files, or if package.json is intentionally exempt, add documentation noting the exemption; locate the file and add the SPDX field at the top-level of the JSON (referencing the "license" key for consistency).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@justfile`:
- Line 796: Update the glob used for OpenClaw profiling artifacts to be
recursive for consistency with the crates pattern: replace the literal pattern
"integrations/openclaw/*.profraw" with a recursive glob
"integrations/openclaw/**/*.profraw" so it matches files in any subdirectory
(aligning with "crates/**/*.profraw").
---
Outside diff comments:
In `@integrations/openclaw/package.json`:
- Line 1: Package JSON lacks the repo's JSON SPDX marker; update
integrations/openclaw/package.json to include the SPDX identifier alongside the
existing "license": "Apache-2.0" (e.g., add a top-level
"SPDX-License-Identifier": "Apache-2.0") so it matches the repo's JSON SPDX
convention used in other files, or if package.json is intentionally exempt, add
documentation noting the exemption; locate the file and add the SPDX field at
the top-level of the JSON (referencing the "license" key for consistency).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 53498738-2510-4a4e-81d0-d6823f4fab4b
📒 Files selected for processing (2)
integrations/openclaw/package.jsonjustfile
📜 Review details
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{rs,py,js,ts,mjs,go,sh,toml,yml,yaml,md,json,css,html}
📄 CodeRabbit inference engine (AGENTS.md)
Keep SPDX headers on source, docs, scripts, and configuration files. The project is Apache-2.0.
Files:
integrations/openclaw/package.json
**/package.json
📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Update Node.js package names during coordinated rename operations
Files:
integrations/openclaw/package.json
integrations/openclaw/package.json
📄 CodeRabbit inference engine (.agents/skills/update-project-version/SKILL.md)
Ensure
integrations/openclaw/package.jsonnpm plugin version stays aligned with the workspace-rootpackage-lock.json
Files:
integrations/openclaw/package.json
{docs/**,README.md,**/Cargo.toml,**/package.json,**/*.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Ensure renamed public surfaces are reflected consistently in manifests and docs for large or public-facing changes
Files:
integrations/openclaw/package.json
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}
⚙️ CodeRabbit configuration file
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}: Review automation changes for reproducibility, pinned versions where appropriate, secret handling, and consistency with the documented validation matrix.
Pay attention to commands that need generated native artifacts, FFI libraries, or platform-specific environment variables.
Files:
justfile
🔇 Additional comments (2)
integrations/openclaw/package.json (1)
59-59: LGTM!justfile (1)
785-785: LGTM!
Signed-off-by: David Gardner <dagardner@nvidia.com>
…ound error (at least with node v20)" This reverts commit c8b4944. Signed-off-by: David Gardner <dagardner@nvidia.com>
Salonijain27
left a comment
There was a problem hiding this comment.
Approved from a dependency point of view
|
/merge |
Overview
Set minimum Node.js version to 24, since that is the version we use in CI.
Details
*.profrawfiles from root of the repo andintegrations/openclaw/Where should the reviewer start?
Summary by CodeRabbit
Chores
Documentation