docs(launcher): scope CLAUDE.md "new model config" section to Megatron-LM PTQ#1547
docs(launcher): scope CLAUDE.md "new model config" section to Megatron-LM PTQ#1547h-guo18 wants to merge 1 commit into
Conversation
…n-LM PTQ The section is Megatron-LM PTQ-specific (env vars MLM_MODEL_CFG / QUANT_CFG only apply to that pipeline), but the generic title was being read as universal — e.g. by CodeRabbit, which flagged a streaming EAGLE3 yaml for missing those vars. Retitle and add a lead-in pointing other pipelines to sibling yamls. Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the launcher documentation to clarify the process for adding a new Megatron-LM PTQ model configuration. The section heading is scoped from generic "Adding a New Model Config" to specifically "Adding a New Megatron-LM PTQ Model Config," and the instructions now specify the exact YAML location and explain how to derive other pipeline configurations from sibling files. ChangesMegatron-LM PTQ Configuration Guidance
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
+ Coverage 76.83% 76.86% +0.03%
==========================================
Files 477 477
Lines 51954 51954
==========================================
+ Hits 39917 39934 +17
+ Misses 12037 12020 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this PR do?
Type of change: docs
The "Adding a New Model Config" section in
tools/launcher/CLAUDE.mdis written for the Megatron-LM PTQ pipeline specifically — its env vars (MLM_MODEL_CFG,QUANT_CFG) only apply there. But the generic title and step 1'smegatron_lm_ptq.yamlfilename were being read as universal:MLM_MODEL_CFG/QUANT_CFG, citing this section as the authoritative guideline.tools/launcher/examples/**yaml sets these vars (HF PTQ, HF / offline / streaming EAGLE3, dflash all use different env conventions).This PR retitles the section to make scope explicit and adds a one-line lead-in pointing other pipelines at sibling yamls as templates.
Before your PR is "Ready for review"
Summary by CodeRabbit