[Tests]: Precommit Check for Spec-Dec Recipes

[h-guo18]

What does this PR do?

Type of change: new tests / tooling

Adds pre-commit validation for speculative-decoding recipes (the existing check-modelopt-recipes hook only ran on PTQ) and for launcher YAML references into the recipe library.

• tools/precommit/check_modelopt_recipes.py: accept speculative_eagle / speculative_dflash / speculative_medusa in addition to ptq, so per-model spec-dec recipes (e.g. modelopt_recipes/models/Qwen3-8B/dflash.yaml) get full Pydantic validation via load_recipe() at commit time.
• tools/precommit/check_launcher_yaml.py (new): scans every tools/launcher/examples/**/*.yaml for --config <path> and data.chat_template=<path> references, verifies the resolved files exist, and runs load_recipe() on any path under modelopt_recipes/. Skips <<global_vars.x>> interpolation. pass_filenames: false so recipe-side edits also re-validate all launcher references.

Usage

pre-commit run check-modelopt-recipes --all-files
pre-commit run check-launcher-yaml --all-files

Testing

Smoke-tested both hooks manually:

Scenario	Result
spec-dec recipe with dflash_block_size: not_an_int	exit 1, Pydantic int_parsing error
launcher YAML with non-existent --config path	exit 1, source file + resolved path reported
launcher YAML with non-existent data.chat_template path	exit 1
Current repo state (all valid)	exit 0

Before your PR is "Ready for review"

• Is this change backward compatible?: ✅
• If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A
• Did you write any new necessary tests?: ✅ (hooks themselves are the tests)
• Did you update Changelog?: N/A
• Did you get Claude approval on this PR?: ❌ pending

Additional Information

Motivated by the per-model recipe migration in #TBD — without these hooks, broken --config paths and recipe schema typos surface only at CI or runtime.

Summary by CodeRabbit

Release Notes

• Chores
  • Strengthened validation checks for launcher configurations and recipe files to automatically detect and report configuration errors.
  • Extended recipe validation coverage to support additional recipe types.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2fd2b0ec-e98a-4439-aa64-31207f0636cc

📥 Commits

Reviewing files that changed from the base of the PR and between c9098b6 and b9296fc.

📒 Files selected for processing (3)

• .pre-commit-config.yaml
• tools/precommit/check_launcher_yaml.py
• tools/precommit/check_modelopt_recipes.py

---

📝 Walkthrough

Walkthrough

This pull request introduces a new pre-commit hook to validate launcher YAML files and expands the existing recipe validation hook to support speculative-decoding recipe types. The launcher validation extracts path references from YAML configs and templates, resolves them to filesystem locations, and validates referenced recipe configs by calling load_recipe().

Changes

Pre-commit validation system enhancements

Layer / File(s)	Summary
Launcher YAML validation hook tools/precommit/check_launcher_yaml.py, .pre-commit-config.yaml	New pre-commit hook that scans launcher example YAML files, safely parses their structure, extracts path-bearing --config and .chat_template= arguments from pipeline tasks, resolves paths using launcher-relative and symlink rules, verifies file existence, and validates recipe configs under modelopt_recipes/ by calling load_recipe(). Hook is registered in pre-commit config with glob-based file filtering.
Recipe type expansion tools/precommit/check_modelopt_recipes.py	Introduces _SUPPORTED_RECIPE_TYPES constant enumerating PTQ and speculative-decoding recipe types (EAGLE, DFlash, Medusa), updates _is_recipe_file() to accept any supported type instead of PTQ-only, and clarifies documentation that directory-format recipes remain PTQ-only while single-file recipes support the expanded type list.

---

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: adding pre-commit checks for speculative-decoding recipes and launcher YAML validation.
Docstring Coverage	✅ Passed	Docstring coverage is 88.89% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Security Anti-Patterns	✅ Passed	No unsafe patterns found: no torch.load weights_only=False, numpy allow_pickle=True, trust_remote_code=True, eval/exec, or nosec comments. Code uses yaml.safe_load and guards modelopt imports.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch haoguo/recipe-precommit-checks

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.75%. Comparing base (c9098b6) to head (b9296fc).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1527   +/-   ##
=======================================
  Coverage   76.75%   76.75%           
=======================================
  Files         476      476           
  Lines       51811    51811           
=======================================
+ Hits        39767    39768    +1     
+ Misses      12044    12043    -1     

Flag	Coverage Δ
unit	52.61% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[shengliangxu]

A bit confused by the scope: is the change for general launcher yaml check or for spec-dec specific recipes check?

[h-guo18]

A bit confused by the scope: is the change for general launcher yaml check or for spec-dec specific recipes check?

Both. It adds checks for spec-dec recipes and all yamls that appears in the general launcher.

[shengliangxu]

hmm, so this behaviour is not expected:

It seems the precommit check script gets activated once there are modifications to any file in the above pattern, but then it will scan all the files even for files that have no modifications.

We should scope to only modified files.