Fix ctest command in README to point at build/test (Issue #1231) - #1232
Open
lennartvoelz wants to merge 1 commit into
Open
Fix ctest command in README to point at build/test (Issue #1231)#1232lennartvoelz wants to merge 1 commit into
lennartvoelz wants to merge 1 commit into
Conversation
enable_testing() is only called in test/CMakeLists.txt, not the top-level CMakeLists.txt, so ctest --test-dir build finds no tests when run from the repo root.
Contributor
Greptile SummaryCorrects the README test command so CTest runs from the directory where MatX registers its tests.
Confidence Score: 5/5The PR appears safe to merge with no actionable issues identified. The documented configuration enables the test subdirectory, where CTest is initialized and tests are registered, so Important Files Changed
Reviews (1): Last reviewed commit: "Fix ctest command in README to point at ..." | Re-trigger Greptile |
cliffburdick
approved these changes
Aug 24, 2026
Collaborator
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable_testing() is only called in test/CMakeLists.txt, not the top-level CMakeLists.txt, so ctest --test-dir build finds no tests when run from the repo root.
Fixes #1231: Change 'build' to 'build/test'.
With the fix, ctest runs the test suite from the repo root.