Skip to content

Fix ctest command in README to point at build/test (Issue #1231) - #1232

Open
lennartvoelz wants to merge 1 commit into
NVIDIA:mainfrom
lennartvoelz:docs/fix-readme-ctest-dir
Open

Fix ctest command in README to point at build/test (Issue #1231)#1232
lennartvoelz wants to merge 1 commit into
NVIDIA:mainfrom
lennartvoelz:docs/fix-readme-ctest-dir

Conversation

@lennartvoelz

Copy link
Copy Markdown

enable_testing() is only called in test/CMakeLists.txt, not the top-level CMakeLists.txt, so ctest --test-dir build finds no tests when run from the repo root.

Fixes #1231: Change 'build' to 'build/test'.

With the fix, ctest runs the test suite from the repo root.

enable_testing() is only called in test/CMakeLists.txt, not the
top-level CMakeLists.txt, so ctest --test-dir build finds no tests
when run from the repo root.
@copy-pr-bot

copy-pr-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Corrects the README test command so CTest runs from the directory where MatX registers its tests.

  • Changes ctest --test-dir build to ctest --test-dir build/test.
  • Aligns the documented command with the preceding MATX_BUILD_TESTS=ON configuration.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

The documented configuration enables the test subdirectory, where CTest is initialized and tests are registered, so build/test is the correct test directory.

Important Files Changed

Filename Overview
README.md The updated CTest path matches the test binary directory created by the documented CMake configuration.

Reviews (1): Last reviewed commit: "Fix ctest command in README to point at ..." | Re-trigger Greptile

@cliffburdick

Copy link
Copy Markdown
Collaborator

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Point CTest command at build/test

2 participants