feat(weight-sync): add ModelExpress trainer publishing#3259
Open
KavinKrishnan wants to merge 3 commits into
Open
feat(weight-sync): add ModelExpress trainer publishing#3259KavinKrishnan wants to merge 3 commits into
KavinKrishnan wants to merge 3 commits into
Conversation
KavinKrishnan
force-pushed
the
kavink/split-3068-trainer
branch
from
July 19, 2026 06:43
51546b1 to
8944e2c
Compare
Extract the trainer-side substrate from NVIDIA-NeMo#3068 so DTensor and Megatron workers can publish native shards without coupling the review to generation, deployment, or benchmark changes. Signed-off-by: Kavin Krishnan <kavink@nvidia.com>
Use the shared WeightSynchronizer boundary, require the public publisher lifecycle, fail closed on unknown Megatron placement, and document the trainer publication contract. Signed-off-by: Kavin Krishnan <kavink@nvidia.com>
KavinKrishnan
force-pushed
the
kavink/split-3068-trainer
branch
from
July 19, 2026 07:23
8944e2c to
5fc0c0b
Compare
Author
|
/ok to test 5fc0c0b |
Document that the current trainer path covers the existing DTensor and Megatron workers while AutoModel DTensor publication remains follow-up work. Signed-off-by: Kavin Krishnan <kavink@nvidia.com>
Author
|
/ok to test 858bf2f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds trainer-side publication for a ModelExpress (MX) weight-refit backend. NeMo RL's
WeightSynchronizerremains the owner of the refit lifecycle; this PR adds the policy operation that a futureModelExpressWeightSynchronizerwill call.The existing DTensor worker and the Megatron worker publish rank-local tensor ownership and topology metadata. Generation-side discovery, transfer, resharding, and installation remain separate reviews.
Changes
publish_weights_for_model_express()to the policy interface and trainer workers.Architecture boundary
This PR does not create a second orchestration path. Existing IPC, HTTP, and NCCL synchronizers are unchanged.
Scope
This PR does not add:
DTensorPolicyWorkerV2/ AutoModel publication;The future synchronizer will own user configuration and construct the internal publisher settings explicitly.
Current status
Partially aligned: rank-local publication is implemented and unit-tested for the existing DTensor worker and the Megatron worker. End-to-end refit requires the generation-worker adapter and the corresponding ModelExpress publisher, planning, and installer APIs.
ModelExpress dependencies
reset_tensors()plus oneadd_tensor()surface for DTensor and Megatron metadata (follow-up review).Relationship to #3068
This is the trainer-publication portion of #3068, separated by ownership and review scope. The umbrella remains a reference for the complete integration.
Test plan