docs(agentic-ci): document client_concurrency_mode in create_resource_provider - #886
Merged
andreatnvidia merged 2 commits intoAug 24, 2026
Conversation
…_provider Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Greptile SummaryAdds the missing
|
| Filename | Overview |
|---|---|
| packages/data-designer-engine/src/data_designer/engine/resources/resource_provider.py | The added parameter documentation accurately reflects the existing None-to-ClientConcurrencyMode.ASYNC behavior. |
Reviews (2): Last reviewed commit: "Merge branch 'main' into agentic-ci/docs..." | Re-trigger Greptile
nabinchha
approved these changes
Aug 24, 2026
Contributor
|
/authorize-agentic-ci |
…-resource-provider-args
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add the missing
Args:entry for the keyword-onlyclient_concurrency_modeparameter in
create_resource_provider(
packages/data-designer-engine/src/data_designer/engine/resources/resource_provider.py).The parameter has existed in the signature
(
client_concurrency_mode: ClientConcurrencyMode | None = None) without acorresponding entry in the Google-style
Args:block, causing docstring vssignature drift.
Why
Detected by the
docs-and-referencesagentic-CI audit as a signature-drivendocstring-drift finding. The fix is mechanical: the added entry notes the
parameter type and its documented default (
ClientConcurrencyMode.ASYNC),which is set explicitly a few lines below in the function body — no invented
semantics.
Testing
make test-engine— 2257 passed.🤖 Generated with Claude Code