fix(moe): preserve DeepEP autograd for empty expert ranks - #3680
Draft
Slyne wants to merge 1 commit into
Draft
Conversation
Signed-off-by: SlyneD <slyned@nvidia.com>
Contributor
|
Hi @Slyne, what failure did you see? Hang? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GroupedExpertsDeepEPpath connected to the tensors returned by DeepEP dispatchMotivation
When one EP rank receives no local expert tokens, the previous fallback built its dummy computation from the original input. That bypassed
FusedDispatchautograd on that rank while peers entered the reverse-dispatch collective, causing either a no-grad error or a distributed timeout during backward.Verification
ruff format --checkandruff checkon the changed Python filesGroupedExpertsDeepEPCPU regression cases passed6351147)The new standalone two-GPU L2 guard is included for CI execution. A CP=2/EP=4 end-to-end smoke remains a draft-PR gate.
Related