feat!: fix and new features to alb, vpc-endpoint, rds modules - #112
Merged
Conversation
…tion - Updated README.md to clarify that security groups must be pre-created and passed explicitly. - Added validation rules in validations.tf to enforce security group presence and validate ALB-specific configurations. - Modified main.tf to ensure security groups are caller-supplied and added ALB-specific security settings. - Introduced new variables for desync mitigation mode, idle timeout, preserve host header, xff header processing mode, enable HTTP/2, and enable cross-zone load balancing in variables.tf.
…ding access logs and listener rules
…e null for NLB - Fixed malformed validation condition that was missing logical AND operator - Now correctly allows null values for NLB deployments - For ALB deployments, enforces valid mode values: off, defensive, strictest, monitor - Updated error message to clarify ALB-only constraint
…ed naming conventions, and additional configuration options
…pport, add validation rules, and update documentation
…and improved validation
…and improved validation
…y, add input validation logic
…ing with delimiter
- Added a new VPC Endpoint module to create Interface and Gateway VPC endpoints with support for custom configurations. - Implemented context and variable definitions for tagging and endpoint configurations. - Created local values to intelligently merge endpoint configurations with module defaults. - Added validations to enforce security and configuration requirements across endpoints. - Updated main module to utilize the new VPC Endpoint module, removing legacy endpoint configurations. - Updated available modules documentation to include the new VPC Endpoint module.
…aller-supplied security groups
Pira-nhs
reviewed
Jul 28, 2026
Pira-nhs
reviewed
Jul 28, 2026
Pira-nhs
previously approved these changes
Jul 28, 2026
Pira-nhs
left a comment
Pira-nhs
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Few comments on the ALB modules.
…d validation checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the ALB module with security group requirements, validation rules, and improved documentation. Introduce a new VPC Endpoint module and enhance existing modules with additional configuration options and validation. Fix validation issues and update documentation for clarity.
Context
These changes ensure that security groups are explicitly managed, improve the overall robustness of the modules, and provide clearer documentation for users. The updates address specific validation issues and enhance logging capabilities across various modules.
Type of changes
Refactoring (non-breaking change)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would change existing functionality)
Bug fix (non-breaking change which fixes an issue)
Checklist
I am familiar with the contributing guidelines
I have followed the code style of the project
I have added tests to cover my changes
I have updated the documentation accordingly
This PR is a result of pair or mob programming
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.