Feature/wpp 10528 resolve build dependency issue#151
Closed
stevesmith-nhs wants to merge 7 commits into
Closed
Conversation
Fixes broken dependency on deprecated api-test-utils package and updates local tooling setup to match latest versions used in other NHS APIs. - switch Python test utility install to pytest-nhsd-apim==5.0.14 to align with latest version used in other NHS APIs - make git hook setup executable and add install-hooks target - pin @openapitools/openapi-generator-cli to 2.32.0 - refresh package-lock.json to current npm lockfile format and resolved deps - ignore generated openapitools.json - remove outdated pyproject.toml comment about old api-test-utils install path
Removed the no-deps flag from Makefile:5, so CI/local now installs transitive dependencies for pytest-nhsd-apim.
replace legacy Node install flow by switching Makefile:7 from npm install --legacy-peer-deps to npm ci for deterministic dependency resolution in pipelines
…ture prerequisites added under install-hooks will be picked up automatically by make install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.