feat(iac): DTOSS-12657 support disabling public access for app-insights#287
Open
josielsouzanordcloud wants to merge 1 commit intomainfrom
Open
feat(iac): DTOSS-12657 support disabling public access for app-insights#287josielsouzanordcloud wants to merge 1 commit intomainfrom
josielsouzanordcloud wants to merge 1 commit intomainfrom
Conversation
Add internet_ingestion_enabled and internet_query_enabled variables to the Application Insights module to allow disabling public access when using Private Link. Both variables default to true to maintain backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new variables to the
app-insightsmodule:internet_ingestion_enabledandinternet_query_enabled. These variables are mapped to the corresponding properties in theazurerm_application_insightsresource.internet_ingestion_enabled: Controls whether public internet ingestion is allowed for Application Insights.internet_query_enabled: Controls whether public internet querying is allowed for Application Insights.Context
To enhance the security posture of our infrastructure, we need the ability to disable public access to Application Insights when it is accessed through Private Link (AMPLS). This change allows projects using this module to enforce private-only access.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.