Skip to content

fix: make time format more strict to stop invalid time date flowing#92

Merged
georgeRobertson merged 2 commits intorelease_v080from
fix/ndit-1166_make_time_format_stricter
Apr 16, 2026
Merged

fix: make time format more strict to stop invalid time date flowing#92
georgeRobertson merged 2 commits intorelease_v080from
fix/ndit-1166_make_time_format_stricter

Conversation

@georgeRobertson
Copy link
Copy Markdown
Contributor

@georgeRobertson georgeRobertson commented Apr 16, 2026

TLDR of changes

Time format domain type in specific circumstances is not strict enough allowing indeterminate values to flow through. E.g. 12:3:12. Is this 12:30 or 12:03? Now it raises an error.

What kind of changes does this PR introduce?

Tick all that apply

  • fix: A bug fix. Correlates with PATCH in SemVer
  • feat: A new feature. Correlates with MINOR in SemVer
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: pip, docker, npm)
  • ci: Changes to CI configuration files and scripts (example scopes: GitLabCI)

Please check if the PR fulfills these requirements

  • I have read and followed the Contributing guidance
  • Docs have been added / updated
  • Tests and Linting in the CI are passing
  • Changes have been reviewed and approved by a Project Maintainer

@sonarqubecloud
Copy link
Copy Markdown

@georgeRobertson georgeRobertson merged commit 11930b8 into release_v080 Apr 16, 2026
4 checks passed
georgeRobertson added a commit that referenced this pull request Apr 16, 2026
## v0.7.3 (2026-04-16)

### Fix

- make time format more strict to stop invalid time date flowing (#92)
- enhance duckdb casting to be less permissive of poorly formatted dates and trim whitespace

### Refactor

- integrated duckdb casting into data contract and added initial spark casting
@georgeRobertson georgeRobertson deleted the fix/ndit-1166_make_time_format_stricter branch April 16, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant