Open
Conversation
9c6959f to
7e8a04a
Compare
29d3332 to
88b96b5
Compare
87ee044 to
b5aafa2
Compare
1f514ec to
1415992
Compare
39e8260 to
e57e53c
Compare
ab0d52c to
405e5b9
Compare
f6b38ee to
6a780bf
Compare
neil-sproston
approved these changes
Apr 16, 2026
Contributor
neil-sproston
left a comment
There was a problem hiding this comment.
Looks sand & proportionate.
| def _with_default_headers(response: MNSResponse) -> Response[str]: | ||
| return Response( | ||
| body=json.dumps(response["response"]), | ||
| body=json.dumps(response["response"]) |
Contributor
There was a problem hiding this comment.
Would it be better to have single if statement above the return rather than two inline if statements?
if response["response"] is not None:
body = json.dumps(response["response"])
headers = {"Content-Type": "application/fhir+json"}
else
body = None
headers = None
return Response(
body=body,
status_code=response["status_code"],
headers=headers
)
Collaborator
Author
There was a problem hiding this comment.
Good point, updated as suggested
12e38ea to
a7d3e1c
Compare
…ning empty payloads
|
|
Deployment Complete
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Addition of a MNS module to publish events.
Context
This change adds in the functionality to support publishing an event based on a stored Test Result.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.