[CDAPI-150]: Added validation ensuring an empty string cannot be prov…

[nhsd-jack-wainwright]

Description

Bug fix to ensure empty strings cannot be provided as either the subject or ODS code as part of a provided Test Result.

Context

This change fixes the validation around the publication of a Test Result to prevent an empty string being provided as either the subject identifier or ODS code.

Type of changes

• Refactoring (non-breaking change)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would change existing functionality)
• Bug fix (non-breaking change which fixes an issue)

Checklist

• I have followed the code style of the project
• I have added tests to cover my changes
• I have updated the documentation accordingly
• This PR is a result of pair or mob programming
• Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

---

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

• I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Deployment Complete

• Preview with mock:
  • URL: https://feature-cdapi-150.dev.endpoints.pathology-laboratory-reporting.national.nhs.uk — Status
    • Smoke test result: ✅ Passed (HTTP 200)
  • Proxy URL: https://internal-dev.api.service.nhs.uk/pathology-laboratory-reporting-pr-105
  • Lambda function: pr-feature-cdapi-150
• Mock endpoints:
  • URL: https://feature-cdapi-150.m.dev.endpoints.pathology-laboratory-reporting.national.nhs.uk
    • Smoke test result: ✅ Passed (HTTP 200)
  • Lambda function: mock-feature-cdapi-150
• Preview with integration:
  • URL: https://feature-cdapi-150.i.dev.endpoints.pathology-laboratory-reporting.national.nhs.uk — Status
    • Smoke test result: ✅ Passed (HTTP 200)
  • Proxy URL: https://internal-dev.api.service.nhs.uk/pathology-laboratory-reporting-pri-105
  • Lambda function: int-feature-cdapi-150