Open
Conversation
nhsd-rebecca-flynn
approved these changes
Apr 15, 2026
|
|
||
| def test_serialization_with_reference(self) -> None: | ||
| nhs_number = "nhs_number" | ||
| patient_id = PatientIdentifier.from_nhs_number(nhs_number) |
Contributor
There was a problem hiding this comment.
Perhaps we could rename this method as create_with?
Collaborator
Author
There was a problem hiding this comment.
Renamed as suggested.
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-113
branch
from
f6b38ee to
6a780bf
Compare
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-149
branch
from
4f08a71 to
7cbebaa
Compare
williamjameswillis
approved these changes
Apr 16, 2026
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-149
branch
2 times, most recently
from
7b53969 to
6bbfd60
Compare
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-113
branch
from
12e38ea to
a7d3e1c
Compare
nhsd-jack-wainwright
changed the base branch from
feature/CDAPI-113
to
feature/CDAPI-72
MohammadPatelNHS
force-pushed
the
feature/CDAPI-72
branch
4 times, most recently
from
04519be to
03f3c01
Compare
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-149
branch
from
c63937b to
f190848
Compare
|
|
Deployment Complete
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addition of a new acceptance test which provides a full test result example (as defined within https://simplifier.net/guide/pathology-fhir-implementation-guide/Home/FHIRAssets/AllAssets/AllProfiles/Examples/Bundles/Full-Blood-Count-Report?version=0.3.1). This PR also includes fixes for some issues found whilst creating this test.
Context
This change provides an acceptance test to ensure that a full Test Result is accepted by the Pathology API, including fields that are not required by the API itself.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.