Skip to content

[GPCAPIM-359] Sort out env vars #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
davidhamill1-nhs wants to merge 16 commits into
base: main
Choose a base branch
from

Merge remote-tracking branch 'origin' into debt/GPCAPIM-359-sort-out-…

c54bb04
Select commit
Loading
Failed to load commit list.
Draft

[GPCAPIM-359] Sort out env vars #174

Merge remote-tracking branch 'origin' into debt/GPCAPIM-359-sort-out-…
c54bb04
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 16, 2026 in 39s

Quality Gate failed

Failed conditions
54.7% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 122 in gateway-api/src/gateway_api/provider/client.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQPmZcdtb57nn6p3&open=AZ2YSQPmZcdtb57nn6p3&pullRequest=174

Check warning on line 122 in gateway-api/src/gateway_api/pds/client.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQSGZcdtb57nn6p9&open=AZ2YSQSGZcdtb57nn6p9&pullRequest=174

Check failure on line 10 in scripts/env/env.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQTfZcdtb57nn6qF&open=AZ2YSQTfZcdtb57nn6qF&pullRequest=174

Check warning on line 90 in gateway-api/src/gateway_api/sds/client.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQRzZcdtb57nn6p5&open=AZ2YSQRzZcdtb57nn6p5&pullRequest=174

Check warning on line 205 in gateway-api/src/gateway_api/sds/client.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQRzZcdtb57nn6p7&open=AZ2YSQRzZcdtb57nn6p7&pullRequest=174

Check warning on line 19 in scripts/env/pds.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQTqZcdtb57nn6qH&open=AZ2YSQTqZcdtb57nn6qH&pullRequest=174

Check warning on line 195 in gateway-api/src/gateway_api/sds/client.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQRzZcdtb57nn6p6&open=AZ2YSQRzZcdtb57nn6p6&pullRequest=174

Check warning on line 7 in .github/actions/start-app/action.yaml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQSlZcdtb57nn6p_&open=AZ2YSQSlZcdtb57nn6p_&pullRequest=174

Check warning on line 19 in scripts/env/sds.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQTSZcdtb57nn6qE&open=AZ2YSQTSZcdtb57nn6qE&pullRequest=174

Check warning on line 28 in infrastructure/images/gateway-api/Dockerfile

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQT6Zcdtb57nn6qI&open=AZ2YSQT6Zcdtb57nn6qI&pullRequest=174

Check warning on line 86 in gateway-api/src/gateway_api/provider/client.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQPmZcdtb57nn6p2&open=AZ2YSQPmZcdtb57nn6p2&pullRequest=174

Check warning on line 19 in gateway-api/src/gateway_api/conftest.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQRWZcdtb57nn6p4&open=AZ2YSQRWZcdtb57nn6p4&pullRequest=174

Check warning on line 4 in scripts/env/provider.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQTGZcdtb57nn6qB&open=AZ2YSQTGZcdtb57nn6qB&pullRequest=174

Check warning on line 80 in gateway-api/src/gateway_api/pds/client.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQSGZcdtb57nn6p8&open=AZ2YSQSGZcdtb57nn6p8&pullRequest=174

Check warning on line 4 in scripts/env/sds.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQTSZcdtb57nn6qD&open=AZ2YSQTSZcdtb57nn6qD&pullRequest=174

Check warning on line 31 in infrastructure/images/gateway-api/Dockerfile

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQT6Zcdtb57nn6qJ&open=AZ2YSQT6Zcdtb57nn6qJ&pullRequest=174

Check warning on line 4 in scripts/env/pds.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an explicit return statement at the end of the function. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQTqZcdtb57nn6qG&open=AZ2YSQTqZcdtb57nn6qG&pullRequest=174

Check warning on line 251 in .github/workflows/preview-env.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQS4Zcdtb57nn6qA&open=AZ2YSQS4Zcdtb57nn6qA&pullRequest=174

Check warning on line 16 in scripts/env/provider.sh

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQTGZcdtb57nn6qC&open=AZ2YSQTGZcdtb57nn6qC&pullRequest=174

Check warning on line 132 in gateway-api/src/gateway_api/pds/client.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_clinical-data-gateway-api&issues=AZ2YSQSGZcdtb57nn6p-&open=AZ2YSQSGZcdtb57nn6p-&pullRequest=174
View more details on SonarQubeCloud