[codex] enforce quality gate#13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CIworkflow with a stablequalityjob for PR and main/master push checks.file://media URI normalization and add regression coverage for local, localhost, remote-host, and relative paths.main.pywith an explicit side-effect module import so pyright reports 0 warnings.Why
Local commit hooks can be bypassed with
--no-verify, so the repository needs an enforced GitHub status check on the protected default branch. The media URI bug and pyright warning were already identified in this working tree and are included so the quality gate starts from a clean baseline.Validation
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/ci.yml"); YAML.load_file(".github/workflows/release.yml"); puts "workflow yaml ok"'ruff check .ruff format --check .pyright rocketchat_*.py main.pypython3 -m py_compile rocketchat_adapter.py rocketchat_realtime.py rocketchat_inbound.py rocketchat_sender.py rocketchat_e2ee.py rocketchat_event.py rocketchat_media.py main.pypython3 -m unittest discover -s tests -p "test_*.py" -vgit commitpre-commit gate: pyright, ruff-check, ruff-format, unittest all passedBranch protection
Configured
mainprotection with required status checkquality, strict up-to-date checks, pull-request gating, admin enforcement, and force-push/delete disabled.