feat: extend coverage-gate with install command and artifact upload - #74
Merged
Conversation
Signed-off-by: rldyourmnd <danil@nddev.it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
coverage-gate.ymlwith four new optional inputs. All default to theprior behaviour, so existing callers are unaffected.
install_command(string, default'') — command that installs the coveragetool, e.g.
cargo install cargo-llvm-cov. Empty to skip; runs before thecoverage command (fail-fast
bash -euo pipefail, value viaenv:).upload_artifact(boolean, defaultfalse) — when true, uploads the coveragereport file as a workflow artifact.
artifact_name(string, defaultcoverage-report) — artifact name.artifact_path(string, default'') — path to the report file to upload;required when
upload_artifactis true.When
upload_artifactis true, a new guarded step uploads via the full-SHA-pinned
actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1(canonical repo pin) with
if-no-files-found: errorso a missing report failsclosed. The install step mirrors the fail-fast runner used by
private-static.yml.Type of change
Threat-model note
No new network egress; the only new third-party action is the already-canonical,
repo-wide
actions/upload-artifactpin (no new supply-chain surface). Nopermission scope change —
upload-artifactuses the default jobGITHUB_TOKENand needs no scope beyond the existing
contents: read.install_commandrunsarbitrary caller bash, but so does the existing
coverage_command— both arecaller-owned and pass through
env:only (no${{ inputs }}inrun:).Permissions diff
No change.
coveragejob keepscontents: readonly.Checklist
# vX.Y.Zcomment(upload-artifact uses the repo's canonical pin).
timeout-minutespresent (unchanged).persist-credentials: falseon read-only checkout (unchanged).${{ inputs.* }}insiderun:— values pass throughenv:.catalog/capabilities.ymlupdated (risk note +last_verified).catalog/tools.ymlupdated (upload-artifactused_byadds coverage-gate).docs/generated/*regenerated (no matrix drift).CHANGELOG.mdupdated under[Unreleased]->### Added.-S) and signed off (-s).Validation note
python3 scripts/validate_all.pyreports only the two pre-existing failures onmain(pinned-actionsandcatalog, both from clusterfuzzlite/rust-supply-chainPRs #68/#69 and unrelated to this change).
coverage-gate.ymlisunverifiedin runtime-coverage (no proven digest), so editing it triggers no runtime-coverage
gate. This PR adds no new failures.