feat: extend pr-hygiene with pr-title and stale options - #71
Merged
Conversation
Signed-off-by: rldyourmnd <danil@nddev.it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
pr-hygiene.ymlwith six new optional inputs. All default to the priorbehaviour, so existing callers are unaffected.
pr-titlejob (amannn/action-semantic-pull-request):pr_title_types(string, default'') — comma-separated allowedconventional-commit types. Empty keeps the action's Conventional Commits
defaults.
pr_title_require_scope(boolean, defaultfalse) — passed torequireScope:.pr_title_subject_pattern(string, default'') — regex constraining the PRtitle subject. Empty applies no extra subject validation.
stalejob (actions/stale):stale_operations_per_run(number, default30) —operations-per-run:.stale_exempt_issue_labels(string, default'') —exempt-issue-labels:.stale_exempt_pr_labels(string, default'') —exempt-pr-labels:.The action's
types:input is newline-delimited, but the workflow input iscomma-separated for ergonomics. A small
Normalize PR-title optionsstepconverts commas to newlines (via
env, no${{ inputs }}interpolation inrun:) and trims empties, leaving the output empty when no types are suppliedso the action falls back to its defaults.
Type of change
Threat-model note
No new third-party action is introduced and no permission scope changes. The new
inputs only configure already-pinned, already-permissioned actions. The
normalize step runs a fixed pipeline over a caller-supplied string with
set -euo pipefail; it cannot execute caller input (noeval/bash -c).Permissions diff
No change.
pr-titlekeepscontents: read+pull-requests: read;stalekeeps
contents: read+issues: write+pull-requests: write.Checklist
# vX.Y.Zcomment.timeout-minutespresent on both jobs (unchanged, viatimeout_minutes).persist-credentials: falseon read-only checkouts (unchanged).${{ inputs.* }}insiderun:— values pass throughenv:.catalog/capabilities.ymlupdated (risk note +last_verified).docs/generated/*regenerated (no matrix drift).CHANGELOG.mdupdated under[Unreleased]->### Added.-S) and signed off (-s).Validation note
python3 scripts/validate_all.pyreports two pre-existing failures onmainthat are unrelated to this change:
pinned-actions(caller-supplied SHApins in
clusterfuzzlite.yml/rust-supply-chain.yml) andcatalog(
clusterfuzzlite-fuzzinguses the non-enum clustertesting-quality). Bothwere introduced by PRs #68/#69 and exist on
origin/main. Every check touchingthis workflow (
workflow-contracts,permissions,examples,generated-docs,runtime-coverage) is OK and this PR adds no new failures.