Skip to content

fix(ruleset): disable extra approval for unattributed agent commits #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rldyourmnd merged 1 commit into from
Sep 14, 2026
+2 −2
Merged

fix(ruleset): disable extra approval for unattributed agent commits #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/rulesets/branch-main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"require_code_owner_review": false,
"require_last_push_approval": false,
"required_review_thread_resolution": true,
"require_extra_approval_for_unattributed_changes": true,
"require_extra_approval_for_unattributed_changes": false,
"allowed_merge_methods": [
"merge"
]
Expand Down
2 changes: 1 addition & 1 deletion docs/08-governance-rulesets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ have to re-derive it:

| Surface | Owner | Status |
| --- | --- | --- |
| `.github/rulesets/branch-main.json` | this repository | Canonical desired state for ruleset `21104086`: `allowed_merge_methods: ["merge"]`, signed commits, thread resolution, zero approvals, extra approval for unattributed changes, **no** required general CI status check. Live settings are not applied from this tree. |
| `.github/rulesets/branch-main.json` | this repository | Canonical desired state for ruleset `21104086`: `allowed_merge_methods: ["merge"]`, signed commits, thread resolution, zero approvals, **no** extra approval for unattributed agent commits, **no** required general CI status check. Live settings are not applied from this tree. |
| `.github/rulesets/tag-semver.json`, `push-hygiene.json` | this repository | Canonical desired state for the repository's own tag and push rules. |
| `NDDev baseline: *` rulesets | the estate control plane | Applied on top, not tracked here. Deleting or editing them from this repository would fight the reconciler. |
| `.gds/compiled-policy.json` | GDS, generated | Generated from the estate policy sources; agrees with live state since the repository-tier override landed. Never edit it here. |
Expand Down
Loading