Fix release-tag protection to match GitHub glob semantics - #23
Merged
Merged
Conversation
Signed-off-by: rldyourmnd <danil@nddev.it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-tag selector used regex-style plus signs, but GitHub evaluates these selectors as fnmatch globs. Normal tags such as 0.1.2 therefore did not match the intended immutable-tag rule. Use a slash-bounded glob and preserve the existing signature, update, deletion and non-fast-forward protections without adding bypasses.
Validation: full scripts/validate_module.sh passed; new regressions cover actual SemVer refs, prereleases, branch refs, nested tags and unrelated aliases; native repository projection apply/verify passed. GitHub ruleset readback/application is a separate consumer operation. Syntax reference: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/creating-rulesets-for-a-repository .