fix(cd): authorize contract outputs and trusted private runner callers - #22
Merged
Merged
Conversation
Signed-off-by: rldyourmnd <danil@nddev.it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five contract authorization jobs compared the requested SHA with an output that did not yet exist, so reviewed commits were rejected before checkout. Some consumers also lacked the intended comparison because a structural test found the misplaced line in the authorization job.
Authorize reviewed main ancestry on the hosted job, then check out only its exact output. Compare that output in each consumer. Before scheduling any private CD runner, require a private caller and a push, dispatch or schedule on its default branch. Public/PR/tag/non-default-branch callers can still use hosted plan/evidence validation; they cannot schedule private runners.
Validation: executed the actual workflow shell blocks against isolated Git repositories. The regression failed in all five affected workflows before the fix. Reviewed commits pass; foreign commits, malformed OIDs and unsafe caller contexts fail before authorization output. All 15 module tests, complete source/registry/trust validation and actionlint pass. No deployments or runner changes were executed.