Name change profile migration not working correctly

[dumptruckman]

It seems that when a player changes their name their inventories data is not being properly migrated. In addition to making this work, some improvements would be needed. We need to create a migrated profile directory to store backups of profiles that get migrated. That way in case anything goes wrong we can manually restore data from the backups.

[SlimeDog]

I assume this is due to storing inventories in

worlds/{WORLD}/{PLAYER_NAME}.json

instead of

worlds/{WORLD}/{PLAYER_UUID}.json

even though the mapping exists in

players/{PLAYER_UUID}.json

Migration would be unnecessary if inventory data were stored by UUID and then mapped back to the player name.

[Ichikuro]

Still a bug. Just caught it on my server. Went to find old players files, and are gone due to it knowing to switch to the UUID but the name didnt carry the files over...I'm guessing?

[winnipeg21]

Sorry to revive old post. I too had/have this issue with players.

[SlimeDog]

I think it's safe to say that everyone does. Note that there is a PR pending.

[winnipeg21]

True, didn't see the PR on my phone lmao

[Thefirstalpha]

I have the same issue, still no fix?

[benwoo1110]

There is a test build here if you want to try #362 (comment)

[benwoo1110]

This PR #428 should have elevated most of the migration issue, do update to the latest test build to try. Appreciate anyone that happens to change their player name to report how it went.

[SlimeDog]

Thanks. I don't have any name changes pending. Hopefully, someone will.

[untuned]

Just had an issue with this, luckily I was able to restore their inventory from a backup, but does anyone have a solution to this?

[nicegamer7]

@untuned what version of MV Inventories were you using? This should be fixed as of 4.2.3, but if not, I had another unmerged change that could help.

[untuned]

@untuned what version of MV Inventories were you using? This should be fixed as of 4.2.3, but if not, I had another unmerged change that could help.

[21:09:35 INFO]: Multiverse-Inventories version 4.2.4-SNAPSHOT-b524
[21:09:35 INFO]: Author: dumptruckman