KeplerianFromStateVectors() improvements#2203
Merged
lamont-granquist merged 1 commit intoMay 23, 2026
Merged
Conversation
Fixes my janky method of dealing with retrograde orbits by properly using retrograde equinoctial elements for retrograde cases. Adds quite a few tests. Fixes the random forward-and-back tests to be pseudo-random to eliminate any pseudo-random failures. Fixed an issue in Clamp2Pi that could result in small negative values annoying returning exactly 2Pi instead of [0,2Pi) Now using an exact EPS value instead of the one I historically had been using for years that was rounded off to be slightly too small.
lamont-granquist
deleted the
lcg/keplerian-from-state-vectors-improvements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes my janky method of dealing with retrograde orbits by properly using retrograde equinoctial elements for retrograde cases.
Adds quite a few tests.
Fixes the random forward-and-back tests to be pseudo-random to eliminate any pseudo-random failures.
Fixed an issue in Clamp2Pi that could result in small negative values annoying returning exactly 2Pi instead of [0,2Pi)
Now using an exact EPS value instead of the one I historically had been using for years that was rounded off to be slightly too small.