Skip to content

Add ability to change particle type when regrowing#1877

Open
brownd1978 wants to merge 3 commits into
Mu2e:mainfrom
brownd1978:refreco
Open

Add ability to change particle type when regrowing#1877
brownd1978 wants to merge 3 commits into
Mu2e:mainfrom
brownd1978:refreco

Conversation

@brownd1978

Copy link
Copy Markdown
Collaborator

This PR provides an option to force regrown tracks to have a different particle type (mass) than what the KalSeed stores. The default is for regrown tracks to have the same particle type as the KalSeed.

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @brownd1978,
You have proposed changes to files in these packages:

  • Mu2eKinKal
  • RecoDataProducts

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 934d561: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

‼️ It was not possible to prepare the workspace for this test. This is often caused by merge conflicts - please check and try again.

> git diff --check | grep -i conflict
Mu2eKinKal/src/RegrowLoopHelix_module.cc:280: leftover conflict marker
Mu2eKinKal/src/RegrowLoopHelix_module.cc:283: leftover conflict marker
Mu2eKinKal/src/RegrowLoopHelix_module.cc:287: leftover conflict marker
Test Result Details
test with Command did not list any other PRs to include
merge 934d561 into 20895af merge failed

@brownd1978

Copy link
Copy Markdown
Collaborator Author

@FNALbuild run build test

@FNALbuild

Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for a384c3d: build (Build queue - API unavailable)

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at a384c3d.

Test Result Details
test with Command did not list any other PRs to include
merge Merged a384c3d at 20895af
build (prof) Log file. Build time: 04 min 26 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO ➡️ TODO (0) FIXME (2) in 5 files
clang-tidy ➡️ 4 errors 38 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at a384c3d after being merged into the base branch at 20895af.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants