Fix crash when the traveling-salesman local-search budget is exhausted#43
Open
grahamfindlay wants to merge 2 commits into
Open
Fix crash when the traveling-salesman local-search budget is exhausted#43grahamfindlay wants to merge 2 commits into
grahamfindlay wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsp_fasthas a budget (n_iter) for the maximum number of improving moves.Usually convergence never exhausts the budget, but when it did, it was wasn't leaving any of the
-1sentinels inseg_len.This caused an
IndexErrorwhen it went to check how many moves were completed, because it was assuming that at least one sentinel always remained (np.nonzero(seg_len == -1)[0][0]).