feat(tui): support j/k navigation in non-search pickers#175
Open
wenyuanw wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 5316e8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue; this fixes an inconsistency in TUI picker navigation.
Problem
Some TUI selection popups, including the
/loginplatform selector, only accepted↑/↓for navigation even though other TUI views already support Vim-stylej/kmovement. This made keyboard behavior inconsistent across popups.What changed
Added
j/knavigation to the shared non-search picker list handling, using the existing printable-key decoding path so Kitty keyboard protocol input works correctly.Searchable pickers keep
j/kas search input rather than treating them as navigation, so model/provider search behavior is unchanged. The change includes focused unit coverage, a changeset for@moonshot-ai/kimi-code.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.