[Fix] Validate num_sms before communication context initialization - #10
Open
morluto wants to merge 1 commit into
Open
[Fix] Validate num_sms before communication context initialization#10morluto wants to merge 1 commit into
morluto wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7.
Summary
Validate
num_smsbefore allocating the communication context or compilingcommunication kernels.
Explicit values must be positive integers no greater than the current CUDA
device's physical SM count. When omitted,
num_smsnow resolves tomin(32, device_sm_count).Problem
MoonEP exposes
num_smsas the number of SMs assigned to communication, butpreviously accepted any positive integer. Oversized values reached context
allocation and kernel compilation before producing a configuration-dependent
CUDA failure.
The previous fixed default of 32 could also be unsuitable for devices with
fewer than 32 physical SMs.
This change establishes a conservative MoonEP API bound. It does not attempt
to calculate each compiled kernel's occupancy-dependent cooperative launch
limit.
Change
TypeError.ValueError.Noneto the smaller of 32 and the device SM count.Validation
python3 -m pytest -q tests/test_api_validation.py— 7 passed.python3 -m py_compile moonep/api.py tests/test_api_validation.py— passed.limit, and default resolution on a smaller device.