Skip to content

home row cleanup#191

Merged
RadicalMuffinMan merged 8 commits into
Moonfin-Client:masterfrom
jmawet:displayseerrrows
Jul 15, 2026
Merged

home row cleanup#191
RadicalMuffinMan merged 8 commits into
Moonfin-Client:masterfrom
jmawet:displayseerrrows

Conversation

@jmawet

@jmawet jmawet commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Remove displaySeerrRows toggle from defaults config since it was retired on core

Add missing home row options to default config

Related Issues

Link related issues or tickets separated by commas.

  • Closes #
  • Fixes #
  • Related to #

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • API / endpoint change
  • Settings schema change
  • Documentation update
  • Build/CI change
  • Other (describe):

Area

  • Settings sync / profiles
  • Admin defaults / config page
  • Ratings (MDBList / TMDB)
  • Notifications / Push (FCM / relay)
  • Seerr integration
  • Games / Emulators
  • Custom home rows
  • Web Client (Go to Moonfin-Core repo)
  • Other / shared

Changes Made

List the key changes included in this PR.

  • remove options for displaySeerrRows for both emby and jf plugins
  • kept it in syncable settings keys so it will still sync for existing clients, but removed from default config page so no one can set a default value for a setting that no longer exists
  • add "external lists" home rows tab
  • add missing home rows to config page

Client Impact

Does this need matching changes in a client repo (Core, Smart-TV, Roku)?

Compatibility

  • Change to the settings profile is additive only, no renamed or removed properties
  • New properties use the same type the client sends (a client bool maps to bool?, an int to int?)
  • Migration added for any renamed or removed settings
  • Older clients still work, unknown fields are ignored and no keys were removed

Testing

Describe how this change was tested.

  • Built the plugin and deployed to a Jellyfin server
  • Verified against a live client (which one:)
  • Manual testing completed
  • Not tested (explain why):

Test Steps

Screenshots (if applicable)

Include config page screenshots or request/response samples where relevant.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced
  • Any new setting keys match the client-side keys exactly

@jmawet
jmawet marked this pull request as draft July 15, 2026 19:18
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

Build Successful

The plugin compiled successfully against .NET 8 / Jellyfin 10.10.0.

Property Value
Commit 9daba1f
Workflow Build #204

@jmawet
jmawet marked this pull request as ready for review July 15, 2026 20:41
@RadicalMuffinMan
RadicalMuffinMan merged commit 8af02a2 into Moonfin-Client:master Jul 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants