Skip to content

Fix verifier quarantine regression in remote share checks#169

Merged
MoneroOcean merged 1 commit into
masterfrom
codex/propose-fix-for-share-verifier-vulnerability
May 22, 2026
Merged

Fix verifier quarantine regression in remote share checks#169
MoneroOcean merged 1 commit into
masterfrom
codex/propose-fix-for-share-verifier-vulnerability

Conversation

@MoneroOcean
Copy link
Copy Markdown
Owner

Motivation

  • Restore the previous quarantine behavior for remote share verifiers so a recently failing verifier is not repeatedly selected and causing expensive local slow-hash fallbacks.
  • Revert the excessive alert/quarantine thresholds that delayed operator notification and allowed flapping verifiers to continue receiving work.
  • Reduce availability risk where unauthenticated miners could cause repeated local hashing by submitting shares while a remote verifier is flapping or down.

Description

  • Changed verifier failure alert thresholds in lib/coins/index.js back from >100 to >10 for the timeout, bad JSON, and socket error paths so operators are notified earlier.
  • Restored the quick quarantine policy in the verifier selection logic by skipping any host that has a recent failure in the last 60 seconds (shareVerifyQueueErrorCount[index] > 0), with the existing 127.0.0.1 exception preserved.
  • The single file modified is lib/coins/index.js where the verification queue error handling and queue selection were adjusted to prevent reselecting recently failed verifiers.

Testing

  • Ran npm test --silent in this environment and the test harness failed to start due to a missing dependency (protocol-buffers), so automated tests did not complete.

Codex Task

@MoneroOcean MoneroOcean merged commit c51f603 into master May 22, 2026
2 checks passed
@MoneroOcean MoneroOcean deleted the codex/propose-fix-for-share-verifier-vulnerability branch May 22, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant