Remove Docker bridge MySQL principal with default credentials#166
Merged
MoneroOcean merged 1 commit intoMay 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
deployment/base.sqlcreated a non-loopback MySQL principalpool@172.17.0.1using the repository default password which broadened privileged DB access beyond loopback and exposed sensitive tables and configuration.Description
CREATE USER pool@172.17.0.1line and the corresponding `GRANT ALL ON pool.* TO pool@`172.17.0.1fromdeployment/base.sql, preserving the existing127.0.0.1andlocalhostprincipals.Testing
sed -n '1,40p' deployment/base.sqlandnl -ba deployment/base.sql | sed -n '1,15p'and confirmed the file no longer contains the172.17.0.1user or itsGRANT ALLentry; these checks succeeded.Codex Task