DX Improvements#130
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| let minute = ((total_seconds % 3600.0) / 60.0).floor() as i64; | ||
| let second_val = (total_seconds % 3600.0) % 60.0; | ||
| let second = second_val.floor() as i64; | ||
| let subsecond = second_val - second as f64; |
There was a problem hiding this comment.
The as_time method no longer outputs subsecond precision, even though to_calendar_components now extracts it. This is a change in behavior from the previous is_subsecond flag logic. If subsecond precision is required in string output, consider adding an argument or a separate method for it.
| (year, month, day, hour, minute, second, subsecond) | ||
| } | ||
|
|
||
| pub fn as_date(&self) -> String { |
There was a problem hiding this comment.
Similar to as_time, the as_datetime method also omits subsecond precision in its string output. If subsecond precision is needed for datetime string representations, this should be addressed.
| second as f64, | ||
| subsecond, | ||
| )) | ||
| } |
There was a problem hiding this comment.
The DateTimeModifier::Ceiling and DateTimeModifier::Floor variants are defined in modifiers.rs but are not handled in apply_modifier. This will result in a generic "Modifier not implemented" error if these are encountered. Consider implementing their logic or removing them if they are not intended for use.
|
AI review done up to commit: 021a3d8 AI Review Summary:Code review completed. Reviewed 2 files with 3 comments. |
FletcherDares
force-pushed
the
fletcher/dx-improvements
branch
from
021a3d8 to
f615a3d
Compare
1 participant
No description provided.