fix: bump tiktoken to 0.8.0 for litellm 1.84.8 - #1430
Open
sufubao wants to merge 1 commit into
Open
Conversation
litellm 1.84.8 requires tiktoken>=0.8.0,<1.0, but requirements.txt still pinned tiktoken==0.7.0 from before the litellm floor was raised in ModelTC#1427. This makes pip resolution fail with ResolutionImpossible when building images that install requirements.txt from a clean index.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
#1427把 litellm 下界提到了 1.84.8,但requirements.txt里的tiktoken==0.7.0没跟着改。litellm 1.84.8 要求
tiktoken>=0.8.0,<1.0,与钉死的 0.7.0 直接冲突,导致从干净索引安装requirements.txt时 pip 报ResolutionImpossible,镜像构建失败。修复
提到 0.8.0,刚好满足 litellm 1.84.8 的下界,最小改动。