fix: add reports_bucket_name as a parameter used in gtfs validator prerelease generation#1659
Merged
davidgamez merged 2 commits intomainfrom Apr 14, 2026
Merged
fix: add reports_bucket_name as a parameter used in gtfs validator prerelease generation#1659davidgamez merged 2 commits intomainfrom
davidgamez merged 2 commits intomainfrom
Conversation
jcpitre
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
reports_bucket_nameis added as a parameter to the rebuild_missing_validation_report function. This is needed as in GTFS validator prerelease generation, the bucket should be pointing to the staging bucket instead of the production one.In addition, all references to the environment variable named
envwere changed toenvironmentto prevent confusion and misuse.From our AI friend
This pull request standardizes the use of the
ENVIRONMENTenvironment variable (replacing the previousENV) across the codebase, updates related configuration and workflow files, and introduces a new option to override the GCS bucket used for validation report results. It also updates documentation and tests to reflect these changes.Environment variable standardization:
ENVenvironment variable withENVIRONMENTin application code, scripts, configuration files (.env.local), and GitHub Actions workflow files. This ensures consistency and avoids ambiguity in environment configuration across the project. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Validation report bucket override:
reports_bucket_nameparameter to allow overriding the default GCS bucket where validator results are stored. This is useful for testing or pointing production to a staging validator bucket. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Documentation updates:
reports_bucket_nameparameter and its intended usage. [1] [2] [3]Test enhancements:
ENVIRONMENTvariable and thereports_bucket_nameoverride, including new tests for default and custom bucket selection. [1] [2] [3] [4] [5] [6] [7]These changes improve configuration clarity, make environment handling more robust, and add flexibility for validation report storage.
Expected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Testing tips:
Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything