Audit that a declared return type is one an executor writes - #344
Merged
estebanzimanyi merged 1 commit intoAug 28, 2026
Merged
Conversation
A hand-written binding declares its result type twice: in the ScalarFunction registration DuckDB reads, and in the executor template argument that decides which C++ type is written into the result vector. Nothing makes the two agree, and when they disagree the executor writes one width into a vector allocated for another. scripts/return-type-audit.py pairs them by implementation and reports every declared LogicalType no executor writes. A body reaches a type either directly or through a helper template, and both count as written, so a function dispatching through a helper is read as writing the types it instantiates rather than only its last branch. The audit is source-only and runs as its own pull-request job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hand-written binding declares its result type twice: in the ScalarFunction registration DuckDB reads, and in the executor template argument that decides which C++ type is written into the result vector. Nothing makes the two agree, and when they disagree the executor writes one width into a vector allocated for another. scripts/return-type-audit.py pairs them by implementation and reports every declared LogicalType no executor writes. A body reaches a type either directly or through a helper template, and both count as written, so a function dispatching through a helper is read as writing the types it instantiates rather than only its last branch. The audit is source-only and runs as its own pull-request job, answering in seconds rather than waiting on a build.