Pre-stage the covering-column generator (TemporalParquet)#207
Draft
estebanzimanyi wants to merge 1 commit into
Draft
Pre-stage the covering-column generator (TemporalParquet)#207estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
Generate the DuckDB covering-column macros from the MEOS catalog temporal-covering descriptor: covering_spatial (STBOX: xmin..zmax, tmin/tmax, srid), covering_number (TBOX: vmin/vmax, tmin/tmax), and covering_timeOnly (tbool/ttext: tmin/tmax, no spatial box). The covering schema is projected from the single catalog source of truth, not hand-written per type. tools/covering/ holds the vendored descriptor, the generator, the generated covering.sql, a test, and a README. The generated macros use accessors already present in the extension, so covering.sql runs on the current build; landing it means vendoring the descriptor from the merged MEOS-API change, wiring covering.sql into the extension load-time SQL, and re-verifying against the pinned libmeos.
estebanzimanyi
force-pushed
the
feat/covering-prestage
branch
from
d63c794 to
0d84825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft / pre-stage of the MobilityDuck covering-column emission for the MobilityLakehouse — the binding's projection of the MEOS catalog
temporalCoveringdescriptor (MEOS-API #24).tools/covering/codegen_covering.pyreads the descriptor and emits DuckDB macros that materialise the TemporalParquet covering columns of a temporal value:covering_spatial(t)— STBOX covering (xmin..zmax,tmin/tmax,srid) for the spatial temporal typescovering_number(t)— TBOX covering (vmin/vmax,tmin/tmax) for the numeric onesso a writer materialises identical covering columns next to the lossless value, and the table prunes at the Parquet row-group and Iceberg manifest level. The covering schema is generated from the catalog, not hand-written per type.
Verified
The generator is pin-independent, and the emitted
covering.sqluses box accessors already in the extension, so it runs on the current build today —tools/covering/test_covering.sqlreturns the covering columns for atgeogpoint(xmin=4.4 … zmin=NULL (2D) … srid=4326) and atfloat(vmin=1.5 vmax=9.2 …).To land (post-pin)
temporal-covering.jsonfrom the merged MEOS-API test(parity): batch 2 — boolops / textfuncs / compops / posops / aggfuncs #24,covering.sqlinto the extension's load-time SQL,libmeos.Kept as a draft until #24 merges and the next ecosystem pin lands.