Exit zero from a refresh that succeeded - #87
Merged
estebanzimanyi merged 2 commits intoAug 27, 2026
Merged
Conversation
The refresh's dependency step reads requirements.txt, resolves each distribution it names, and installs only the ones absent from the interpreter, falling back to the user site when a system-wide write is refused. An interpreter that already carries libclang and jsonschema needs no install, and one marked externally managed under PEP 668 — the Debian and Ubuntu default — no longer ends the refresh before the catalog is derived.
The closing summary prints its optional libmeos and jar lines from `if` blocks. An AND-list whose test is false was the script's last command and left the exit status at 1, so every consumer that builds neither — MobilityDuck and the other non-JVM bindings — saw a completed refresh report failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The closing summary prints its optional libmeos and jar lines from
ifblocks, so a completed refresh carries an exit status of zero. A consumer that builds neither a libmeos nor a jar — MobilityDuck and the other non-JVM bindings — reads success from a refresh that succeeds.