Define the optional family macros when parsing the headers#47
Merged
estebanzimanyi merged 1 commit intoJul 11, 2026
Merged
Conversation
A handful of public declarations in the core headers are guarded by `#if <FAMILY>` (for example `meos_initialize_pointcloud`, `rtree_create_tpcbox`, and the `pointcloud_basetype` / `pointcloudset_type` / `tpointcloud_temptype` catalog predicates behind `#if POINTCLOUD` in meos.h and meos_catalog.h). The family headers themselves are unguarded, so their functions were captured, but these gated core-header declarations were preprocessed out and never reached the catalog. MobilityDB's `ALL=ON` build enables every optional family, each defining a `-D<FAMILY>=1` compile flag. Mirror that here so the catalog reflects the full all-families surface. The family list is kept alphabetically ordered, in sync with the CMakeLists.txt `if(ALL)` loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handful of public declarations in the core headers are guarded by
#if <FAMILY>— for examplemeos_initialize_pointcloudandrtree_create_tpcboxinmeos.h, and thepointcloud_basetype/pointcloudset_type/tpointcloud_temptypecatalog predicates behind#if POINTCLOUDinmeos_catalog.h. The family headers themselves are unguarded, so their functions are captured, but these gated core-header declarations are preprocessed out and never reach the catalog.MobilityDB's
ALL=ONbuild enables every optional family, each defining a-D<FAMILY>=1compile flag. The parser mirrors that build so the catalog reflects the full all-families surface. The family list is alphabetically ordered, in sync with theCMakeLists.txtif(ALL)loop.Against the installed all-families headers the catalog carries 4239 functions (the 5 gated core-header declarations included); structs, enums, and macros are unchanged, and the full test suite passes (165 passed, 14 skipped).