Skip to content

doc: add PR Reviewer Guide + visibility wiring (PR template + README banner)#13

Open
estebanzimanyi wants to merge 1 commit into
MobilityDB:mainfrom
estebanzimanyi:doc/reviewer-guide
Open

doc: add PR Reviewer Guide + visibility wiring (PR template + README banner)#13
estebanzimanyi wants to merge 1 commit into
MobilityDB:mainfrom
estebanzimanyi:doc/reviewer-guide

Conversation

@estebanzimanyi
Copy link
Copy Markdown
Member

@estebanzimanyi estebanzimanyi commented May 10, 2026

Adds doc/contributing/reviewer-guide.md mirroring the canonical reviewer-guide structure used in MobilityDB / MobilityDuck / MobilitySpark, scoped to JMEOS.

Same canonical path (doc/contributing/reviewer-guide.md) as the other three platform repos — reviewers landing in any of the four find the same structure at the same place.

CI dependency: This PR's CI is currently red because of an unrelated apt-mirror / missing-GSL issue affecting all JMEOS workflow runs. The fix is in PR #14 — please merge #14 first; CI on this PR will go green automatically (the branch will be rebased onto main once #14 lands).

Summary

Wires visibility:

  • .github/PULL_REQUEST_TEMPLATE.md links to the guide so contributors are prompted to update it in any commit that opens / closes / restructures a PR.
  • README.md gains a "For contributors and reviewers" section pointing to the guide.

Test plan

…banner)

Adds doc/contributing/reviewer-guide.md mirroring the canonical reviewer-guide
structure used in MobilityDB / MobilityDuck / MobilitySpark, scoped to JMEOS:

 - Dependency chain: PR MobilityDB#9 (multi-module Maven foundation) → PR MobilityDB#12 (MeosLibrary
   sub-interface split for ARM64/Windows/macOS) → downstream MobilitySpark
 - Tier ranking + per-tier review notes
 - Standards checklist (license header, no binary blobs, MeosLibrary split
   preservation, DBL_MAX → null mapping)
 - Cross-repo links to the other three ecosystem reviewer guides

Wires visibility:
 - .github/PULL_REQUEST_TEMPLATE.md links to the guide so contributors are
   prompted to update it in any commit that opens / closes / restructures a PR.
 - README gains a 'For contributors and reviewers' section pointing to the
   guide.

Same canonical path (doc/contributing/reviewer-guide.md) as the other three
platform repos — reviewers landing in any of the four find the same structure
at the same place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant