Skip to content

Use the official xkb name for Arabic layout, not the legacy synonym - #120

Closed
Tverous wants to merge 1 commit into
MoatLab:masterfrom
Tverous:patch-1
Closed

Use the official xkb name for Arabic layout, not the legacy synonym#120
Tverous wants to merge 1 commit into
MoatLab:masterfrom
Tverous:patch-1

Conversation

@Tverous

@Tverous Tverous commented Sep 16, 2023

Copy link
Copy Markdown

The official xkb designation for the Arabic keyboard layout is 'ara'. For the past 15 years or more, xkb has also allowed its identification through the legacy alias 'ar'. In xkeyboard-config 2.39, this alias was eliminated, causing a compilation issue for QEMU:

FAILED: pc-bios/keymaps/ar 
/home/tverous/femu/build-femu/qemu-keymap -f pc-bios/keymaps/ar -l ar
xkbcommon: ERROR: Couldn't find file "symbols/ar" in include paths
xkbcommon: ERROR: 1 include paths searched:
xkbcommon: ERROR: 	/usr/share/X11/xkb
xkbcommon: ERROR: 3 include paths could not be added:
xkbcommon: ERROR: 	/home/tverous/.config/xkb
xkbcommon: ERROR: 	/home/tverous/.xkb
xkbcommon: ERROR: 	/etc/xkb
xkbcommon: ERROR: Abandoning symbols file "(unnamed)"
xkbcommon: ERROR: Failed to compile xkb_symbols
xkbcommon: ERROR: Failed to compile keymap

The change in the upstream xkeyboard-config that eliminates the compat mapping is::
https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/commit/470ad2cd8fea84d7210377161d86b31999bb5ea6

@huaicheng

Copy link
Copy Markdown
Contributor

Thanks for catching this. ara is indeed the official xkb name and ar the legacy synonym.

The same change is already in master — it came in with the QEMU 9.0 rebase (25a24d4b8), a few months after you opened this, so the PR itself never got applied. Sorry it sat here that long.

@huaicheng

Copy link
Copy Markdown
Contributor

Thanks — correct diagnosis, and the same fix is now on master.

pc-bios/keymaps/meson.build carries 'ar': '-l ara'; it came in with the QEMU 10.1.0 rebase (eafddfd), which picked up the upstream change for the xkeyboard-config 2.39 alias removal. Builds on current distributions no longer fail on the ar keymap.

Closing as already applied — sorry this stayed open until the rebase overtook it.

@huaicheng huaicheng closed this Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants