Conversation
MistyKuu
force-pushed
the
claude/fix-validation-endpoint-filter
branch
from
2daebe1 to
2c6409a
Compare
…ndpointFilter resolves Previously the generator emitted ValidationEndpointFilter.g.cs whenever `Microsoft.AspNetCore.Http.Results` resolved in the compilation. That type lives in Microsoft.AspNetCore.Http.Results.dll, while the generated source also calls `RouteHandlerBuilder.AddEndpointFilter(...)` which lives in Microsoft.AspNetCore.Http.Extensions.dll (class EndpointFilterExtensions). Test projects that pulled `Results` in transitively — e.g. via a ProjectReference to an ASP.NET Core web sample used by WebApplicationFactory — but did not wire up the full minimal-API extension surface tripped the gate and then failed to compile with: RouteHandlerBuilder does not contain a definition for AddEndpointFilter Gate now requires all three types the emitted source uses — RouteHandlerBuilder, Results, and EndpointFilterExtensions — so the filter source is only emitted when the compilation actually has a chance of compiling it.
MistyKuu
force-pushed
the
claude/fix-validation-endpoint-filter
branch
from
2c6409a to
51e0814
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ndpointFilter resolves
Previously the generator emitted ValidationEndpointFilter.g.cs whenever
Microsoft.AspNetCore.Http.Resultsresolved in the compilation. That type lives in Microsoft.AspNetCore.Http.Results.dll, while the generated source also callsRouteHandlerBuilder.AddEndpointFilter(...)which lives in Microsoft.AspNetCore.Http.Extensions.dll (class EndpointFilterExtensions).Test projects that pulled
Resultsin transitively — e.g. via a ProjectReference to an ASP.NET Core web sample used by WebApplicationFactory — but did not wire up the full minimal-API extension surface tripped the gate and then failed to compile with:RouteHandlerBuilder does not contain a definition for AddEndpointFilter
Gate now requires all three types the emitted source uses — RouteHandlerBuilder, Results, and EndpointFilterExtensions — so the filter source is only emitted when the compilation actually has a chance of compiling it.