Skip to content

[Dto]: fix CRUD test generator — detect ImTiredOfCrud, add per-op tes… #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MistyKuu merged 1 commit into from
Apr 21, 2026
Merged

[Dto]: fix CRUD test generator — detect ImTiredOfCrud, add per-op tes… #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
153 changes: 138 additions & 15 deletions packages/ZibStack.NET.Dto/src/ZibStack.NET.Dto/DtoGenerator.CrudGeneration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,16 +669,23 @@ private static void ScanForCrudApi(INamespaceSymbol ns, List<CrudTestInfo> resul
{
foreach (var type in ns.GetTypeMembers())
{
foreach (var attr in type.GetAttributes())
// [CrudApi] is the primary source; [ImTiredOfCrud] (from ZibStack.NET.UI) is the
// bridge alias that emits the same endpoints. Tests must cover both or they
// silently miss every [ImTiredOfCrud]-decorated entity.
AttributeData? attr = null;
foreach (var a in type.GetAttributes())
{
var attrName = attr.AttributeClass?.Name;
if (attrName != "CrudApiAttribute") continue;
var attrName = a.AttributeClass?.Name;
if (attrName == "CrudApiAttribute") { attr = a; break; }
if (attrName == "ImTiredOfCrudAttribute" && attr is null) attr = a;
}
if (attr is null) continue;

var info = new CrudTestInfo
{
ClassName = type.Name,
Namespace = type.ContainingNamespace.IsGlobalNamespace ? null : type.ContainingNamespace.ToDisplayString(),
};
var info = new CrudTestInfo
{
ClassName = type.Name,
Namespace = type.ContainingNamespace.IsGlobalNamespace ? null : type.ContainingNamespace.ToDisplayString(),
};

foreach (var arg in attr.NamedArguments)
{
Expand Down Expand Up @@ -840,11 +847,10 @@ private static void ScanForCrudApi(INamespaceSymbol ns, List<CrudTestInfo> resul
}
}

info.Properties.Add(propInfo);
}

results.Add(info);
info.Properties.Add(propInfo);
}

results.Add(info);
}
foreach (var sub in ns.GetNamespaceMembers())
ScanForCrudApi(sub, results);
Expand Down Expand Up @@ -1019,6 +1025,95 @@ private static string GenerateCrudTestSource(CrudTestInfo info)
sb.AppendLine(" }");
}

// Standalone per-endpoint tests — emitted IN ADDITION to FullCrudCycle so the
// test runner reports one failure per broken endpoint instead of a single
// opaque "combined cycle failed". Also covers Operations combinations that
// exclude one of the four so FullCrudCycle never emits (e.g. Write-only).

// Update — PATCH then verify value actually changed via GET
if ((info.Operations & OpUpdate) != 0 && (info.Operations & OpCreate) != 0 && (info.Operations & OpGetById) != 0)
{
var verifyProp = updateProps.FirstOrDefault(p => !IsUnsupportedTestType(p.CSharpType) && p.CSharpType is "string" or "System.String");

sb.AppendLine();
sb.AppendLine(" [Fact]");
sb.AppendLine($" public async Task Update_ModifiesEntity()");
sb.AppendLine(" {");
sb.AppendLine($" var createResponse = await _client.PostAsJsonAsync(\"/{route}\", {createBody});");
sb.AppendLine(" Assert.Equal(HttpStatusCode.Created, createResponse.StatusCode);");
sb.AppendLine(" var location = createResponse.Headers.Location!.ToString();");
sb.AppendLine(" var before = await _client.GetFromJsonAsync<System.Text.Json.JsonElement>(location);");
sb.AppendLine();
sb.AppendLine($" var patchContent = JsonContent.Create({updateBody});");
sb.AppendLine(" var updateResponse = await _client.PatchAsync(location, patchContent);");
sb.AppendLine(" Assert.Equal(HttpStatusCode.OK, updateResponse.StatusCode);");

if (verifyProp is not null)
{
var jsonName = char.ToLowerInvariant(verifyProp.Name[0]) + verifyProp.Name.Substring(1);
sb.AppendLine();
sb.AppendLine(" var after = await _client.GetFromJsonAsync<System.Text.Json.JsonElement>(location);");
sb.AppendLine($" Assert.NotEqual(before.GetProperty(\"{jsonName}\").GetString(), after.GetProperty(\"{jsonName}\").GetString());");
}

sb.AppendLine(" }");
}
else if ((info.Operations & OpUpdate) != 0 && (info.Operations & OpCreate) != 0)
{
// No GetById to verify: PATCH by id extracted from POST body.
var keyJsonName = char.ToLowerInvariant(info.KeyPropertyName[0]) + info.KeyPropertyName.Substring(1);
var keyGetter = info.KeyType is "int" or "System.Int32" ? "GetInt32" : "GetInt64";

sb.AppendLine();
sb.AppendLine(" [Fact]");
sb.AppendLine($" public async Task Update_ReturnsOk()");
sb.AppendLine(" {");
sb.AppendLine($" var createResponse = await _client.PostAsJsonAsync(\"/{route}\", {createBody});");
sb.AppendLine(" Assert.Equal(HttpStatusCode.Created, createResponse.StatusCode);");
sb.AppendLine($" var body = await createResponse.Content.ReadFromJsonAsync<System.Text.Json.JsonElement>();");
sb.AppendLine($" var id = body.GetProperty(\"{keyJsonName}\").{keyGetter}();");
sb.AppendLine($" var patchContent = JsonContent.Create({updateBody});");
sb.AppendLine($" var updateResponse = await _client.PatchAsync($\"/{route}/{{id}}\", patchContent);");
sb.AppendLine(" Assert.Equal(HttpStatusCode.OK, updateResponse.StatusCode);");
sb.AppendLine(" }");
}

// Delete — DELETE then verify 404 via GET
if ((info.Operations & OpDelete) != 0 && (info.Operations & OpCreate) != 0 && (info.Operations & OpGetById) != 0)
{
sb.AppendLine();
sb.AppendLine(" [Fact]");
sb.AppendLine($" public async Task Delete_RemovesEntity()");
sb.AppendLine(" {");
sb.AppendLine($" var createResponse = await _client.PostAsJsonAsync(\"/{route}\", {createBody});");
sb.AppendLine(" Assert.Equal(HttpStatusCode.Created, createResponse.StatusCode);");
sb.AppendLine(" var location = createResponse.Headers.Location!.ToString();");
sb.AppendLine();
sb.AppendLine(" var deleteResponse = await _client.DeleteAsync(location);");
sb.AppendLine(" Assert.Equal(HttpStatusCode.NoContent, deleteResponse.StatusCode);");
sb.AppendLine();
sb.AppendLine(" var afterDelete = await _client.GetAsync(location);");
sb.AppendLine(" Assert.Equal(HttpStatusCode.NotFound, afterDelete.StatusCode);");
sb.AppendLine(" }");
}
else if ((info.Operations & OpDelete) != 0 && (info.Operations & OpCreate) != 0)
{
var keyJsonName = char.ToLowerInvariant(info.KeyPropertyName[0]) + info.KeyPropertyName.Substring(1);
var keyGetter = info.KeyType is "int" or "System.Int32" ? "GetInt32" : "GetInt64";

sb.AppendLine();
sb.AppendLine(" [Fact]");
sb.AppendLine($" public async Task Delete_ReturnsNoContent()");
sb.AppendLine(" {");
sb.AppendLine($" var createResponse = await _client.PostAsJsonAsync(\"/{route}\", {createBody});");
sb.AppendLine(" Assert.Equal(HttpStatusCode.Created, createResponse.StatusCode);");
sb.AppendLine($" var body = await createResponse.Content.ReadFromJsonAsync<System.Text.Json.JsonElement>();");
sb.AppendLine($" var id = body.GetProperty(\"{keyJsonName}\").{keyGetter}();");
sb.AppendLine($" var deleteResponse = await _client.DeleteAsync($\"/{route}/{{id}}\");");
sb.AppendLine(" Assert.Equal(HttpStatusCode.NoContent, deleteResponse.StatusCode);");
sb.AppendLine(" }");
}

// Bulk create — verify items actually got created
if ((info.Operations & OpBulkCreate) != 0 && (info.Operations & OpGetList) != 0)
{
Expand Down Expand Up @@ -1050,7 +1145,31 @@ private static string GenerateCrudTestSource(CrudTestInfo info)
}

// Bulk delete — verify items actually got deleted (GetById → 404)
if ((info.Operations & OpBulkDelete) != 0 && (info.Operations & OpCreate) != 0 && (info.Operations & OpGetById) != 0)
// Two fallbacks: one when GetById is disabled (status-only) and one when
// even Create is disabled — in the latter case there's nothing to delete
// so we can't sensibly test it; the endpoint exists but not testable here.
if ((info.Operations & OpBulkDelete) != 0 && (info.Operations & OpCreate) != 0 && (info.Operations & OpGetById) == 0)
{
var keyJsonName = char.ToLowerInvariant(info.KeyPropertyName[0]) + info.KeyPropertyName.Substring(1);
var keyGetter = info.KeyType is "int" or "System.Int32" ? "GetInt32" : "GetInt64";

sb.AppendLine();
sb.AppendLine(" [Fact]");
sb.AppendLine($" public async Task BulkDelete_ReturnsOk()");
sb.AppendLine(" {");
sb.AppendLine($" var ids = new List<{info.KeyType}>();");
sb.AppendLine(" for (var i = 0; i < 3; i++)");
sb.AppendLine(" {");
sb.AppendLine($" var r = await _client.PostAsJsonAsync(\"/{route}\", {createBody});");
sb.AppendLine(" Assert.Equal(HttpStatusCode.Created, r.StatusCode);");
sb.AppendLine($" var body = await r.Content.ReadFromJsonAsync<System.Text.Json.JsonElement>();");
sb.AppendLine($" ids.Add(body.GetProperty(\"{keyJsonName}\").{keyGetter}());");
sb.AppendLine(" }");
sb.AppendLine($" var response = await _client.PostAsJsonAsync(\"/{route}/bulk-delete\", ids);");
sb.AppendLine(" Assert.Equal(HttpStatusCode.OK, response.StatusCode);");
sb.AppendLine(" }");
}
else if ((info.Operations & OpBulkDelete) != 0 && (info.Operations & OpCreate) != 0 && (info.Operations & OpGetById) != 0)
{
var keyJsonName = char.ToLowerInvariant(info.KeyPropertyName[0]) + info.KeyPropertyName.Substring(1);
var keyGetter = info.KeyType is "int" or "System.Int32" ? "GetInt32" : "GetInt64";
Expand Down Expand Up @@ -1247,9 +1366,10 @@ private static string GenerateCrudTestSource(CrudTestInfo info)
}

// Complex filter tests: AND, OR, grouped (AND + OR)
// These POST to seed known values — skip when Create isn't enabled.
var intProp2 = info.Properties.FirstOrDefault(p => !p.IsKey && !p.IsComputed && !p.IsNavigation && p.CSharpType is "int" or "System.Int32");
var stringProp2 = info.Properties.FirstOrDefault(p => !p.IsKey && !p.IsComputed && !p.IsNavigation && p.CSharpType is "string" or "System.String" && !p.IsNullable);
if (intProp2 is not null && stringProp2 is not null)
if (intProp2 is not null && stringProp2 is not null && (info.Operations & OpCreate) != 0)
{
var intName = intProp2.Name;
var strName = stringProp2.Name;
Expand Down Expand Up @@ -1330,8 +1450,11 @@ private static string GenerateCrudTestSource(CrudTestInfo info)
}

// Collection navigation with [OneToMany]: Team.Players → create parent + child, then any/all
// Needs Create on the parent route to seed (child route is assumed to
// accept POST too — if it doesn't, the test will still flag the actual
// endpoint mismatch rather than hiding it).
var collectionNav = info.Properties.FirstOrDefault(p => p.IsCollection && p.HasOneToMany && p.NavigationProperties?.Count > 0 && p.ChildRoute is not null);
if (collectionNav is not null)
if (collectionNav is not null && (info.Operations & OpCreate) != 0)
{
var colName = collectionNav.Name;
var childRoute = collectionNav.ChildRoute!;
Expand Down
Loading