fix private non-virtual methods not getting called when not properly overriden - #4123
Open
SinanErmis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I had a problem when using
Network Rigidbody Reliablewhich cost me a few hours to find out why. I am not really sure how anyone haven't noticed yet (this bug is probably older than a year...) but when usingNetwork Rigidbody Reliable,Network Rigidbody Unreliable,Network Rigidbody Unreliable Compressedor their 2D counterparts inUpdateMethod.FixedUpdatemethod, child classes'FixedUpdateimplementation suppresses base classes' one.I changed every Unity lifecycle call in classes inheriting from
NetworkTransformBaseto beprotected virtualand overrode them in child classes. This way lifecycle methods get called even if they are implemented in child classes, also being explicit about them being able to be overridden is also a win I guess.