Skip to content

feat: make out dim a lazy assignment - #399

Merged
stephantul merged 2 commits into
mainfrom
lazy-linear
Oct 13, 2026
Merged

stephantul merged 2 commits into
mainfrom
lazy-linear

Conversation

@stephantul

Copy link
Copy Markdown
Contributor

The out dimensionality of a trainable model was set, but was then always reset on fitting. This is a breaking change, which will be noted in patch notes on a new release. The breaking change arguably only applies to users who manually set out_dim, which has no effect.

@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
model2vec/train/base.py 100.00% <100.00%> (ø)
model2vec/train/classifier.py 100.00% <100.00%> (ø)
model2vec/train/similarity.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium impact] Changes when model heads are constructed during initialization.

The PR appears safe to merge, with two non-blocking corrections to its initialization guidance.

Reviews (1) · Last reviewed commit: "make out dim a lazy assignment" · Reviewed by Greptile

Comment thread model2vec/train/base.py Outdated
Comment thread model2vec/train/base.py Outdated
@stephantul
stephantul merged commit 611a119 into main Oct 13, 2026
11 checks passed
@stephantul
stephantul deleted the lazy-linear branch October 13, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant