Skip to content

Background service for chunking and embedding data - #756

Open
PaulKoudelka wants to merge 52 commits into
MindWorkAI:mainfrom
PaulKoudelka:chunk-data
Open

Background service for chunking and embedding data#756
PaulKoudelka wants to merge 52 commits into
MindWorkAI:mainfrom
PaulKoudelka:chunk-data

Conversation

@PaulKoudelka

Copy link
Copy Markdown
Contributor

No description provided.

@PaulKoudelka

Copy link
Copy Markdown
Contributor Author

Still in progress

@SommerEngineering SommerEngineering left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

Comment thread app/MindWork AI Studio/Settings/DataModel/DataSourceERI_V1.cs Outdated

public DataAgentRetrievalContextValidation AgentRetrievalContextValidation { get; init; } = new();

public DataDataSourceIndexing DataSourceIndexing { get; init; } = new();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this into the app settings.

Comment thread app/MindWork AI Studio/Pages/Information.razor Outdated
<PackageReference Include="MudBlazor" Version="8.15.0" />
<PackageReference Include="MudBlazor.Markdown" Version="8.11.0" />
<PackageReference Include="ReverseMarkdown" Version="5.0.0" />
<PackageReference Include="SQLitePCLRaw.bundle_e_sqlite3" Version="2.1.10" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the newest 3.x release

<ItemGroup>
<PackageReference Include="CodeBeam.MudBlazor.Extensions" Version="8.3.0" />
<PackageReference Include="HtmlAgilityPack" Version="1.12.4" />
<PackageReference Include="Microsoft.Data.Sqlite.Core" Version="9.0.9" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there is a 9.0.18 version?

Comment thread app/MindWork AI Studio/Tools/Databases/DatabaseRole.cs Outdated

namespace AIStudio.Tools.Databases.EmbeddingState;

public abstract class EmbeddingStateClient(string name, string path) : DatabaseClient(name, path)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be renamed according to DataBaseRole.

public abstract Task DeleteDataSourceAsync(string dataSourceId, CancellationToken token);
}

public sealed record EmbeddingStateFile(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move all individual data classes into their own files.


namespace AIStudio.Tools.Databases.EmbeddingState;

public sealed class SqliteEmbeddingStateClientImplementation(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-format lines like this, so we use the typical screen width (~170 chars).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants