Api process failed crash correlation#5586
Open
GittyHarsha wants to merge 7 commits into
Open
Conversation
Adds CrashReport.md spec for the new ICoreWebView2StagingCrashReport API that correlates WebView2 process failures with Watson crash reports. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Fix title from interface name to human-friendly 'Crash Report' - Fix COM IDL code block language tag (cpp -> no tag) - Fix WinRT/NET section headings to 'WinRT and .NET' - Add __fastfail note: fields from WER event log, BucketId empty - Add OOM exception code 0xe0000008 to ExceptionCode doc - Soften CrashReportId dump filename claim - Clean up BucketId doc (remove WER internal field names) - Fix IsCustomCrashReportingEnabled: remove 'network hit' impl detail Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
david-risney
requested changes
May 14, 2026
david-risney
approved these changes
May 15, 2026
- BucketId IS available at event-fire time for HTTP/Mac paths (handler completes upload before ProcessFailed fires). Remove stale 'network throttled/unavailable' case which implied it might not be. - Add enterprise AAD WerReportSubmit as an explicit empty-BucketId case (no HTTP feedback channel, bucket never returned at event time). - CrashReportId: soften 'locate the dump file' claim -- __fastfail crashes have no dump; CrashReportId still identifies the failure. - Background: note that __fastfail produces no dump; CrashReportId still valid in that case. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This reverts commit c82eec6.
CrashReport is null for crashes that bypass the Crashpad crash handler (__fastfail, heap corruption). These still fire ProcessFailed but do not produce a crash report. Host apps that need data for those failure types can query WER Event 1000 directly. Remove WER event-log sourcing language from the summary and property docs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace 'minidump' with 'crash dump' throughout (heap dumps also possible) - Remove implementation-detail language (no fastfail/heap corruption enumeration, no internal mechanism references) - Remove field list from Background and Description intros - Remove marketing noise from Background paragraph - Add external kill as explicit null case - Tighten null-case prose to be implementation-neutral - Add dump filename hint (<CrashReportId>.dmp) to Background - Update IDL comment to cover crash-type failures with no report
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.