Fix variable reference for agent IP in key vault access#14383
Open
BalintBanyasz wants to merge 1 commit into
Open
Fix variable reference for agent IP in key vault access#14383BalintBanyasz wants to merge 1 commit into
BalintBanyasz wants to merge 1 commit into
Conversation
Contributor
|
@BalintBanyasz : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Contributor
|
@BalintBanyasz : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Contributor
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample currently sets the agentIP variable incorrectly:
echo "##vso[task.setvariable variable=agentIP]ip"This stores the literal string ip instead of the value of $ip. As a result, the later Remove-AzKeyVaultNetworkRule step cannot remove the rule that was added, leaving the agent IP in the Key Vault network rules.
The sample should only use:
echo "##vso[task.setvariable variable=agentIP]$ip"Likewise, the removal step should reference the pipeline variable:
$ipRange = "$(agentIP)/32"This ensures the example works end-to-end.