libcurses build failure fix#36
Open
Parithi098 wants to merge 1 commit into
Open
Conversation
Collaborator
Parithi098
commented
May 27, 2026
Parithi098
commented
- Added #else case for #if HAVE_LIBCURSES in eye_plot_graph
- Updated README
Parithi098
force-pushed
the
bugfix/libcurses-guard
branch
from
9ea7d19 to
6a365d0
Compare
pvengat
reviewed
May 27, 2026
| int eye_plot_graph(int *data, bool plot_6p_points, unsigned int w2h_score) | ||
| { | ||
| printf("eye plot requires libcurses support when velocitypci-cli is built\n"); | ||
| return 0; |
Collaborator
There was a problem hiding this comment.
as discussed, can we also give an info during compilation itself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.